Messages in this thread Patch in this message | | | From | NeilBrown <> | Date | Thu, 21 Jun 2007 14:30:45 +1000 | Subject | [PATCH 003 of 8] knfsd: nfsd4: silence a compiler warning in ACL code |
| |
From: "J. Bruce Fields" <bfields@fieldses.org>
Silence a compiler warning in the ACL code, and add a comment making clear the initialization serves no other purpose.
Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu> Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output ./fs/nfsd/nfs4acl.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff .prev/fs/nfsd/nfs4acl.c ./fs/nfsd/nfs4acl.c --- .prev/fs/nfsd/nfs4acl.c 2007-06-21 13:46:39.000000000 +1000 +++ ./fs/nfsd/nfs4acl.c 2007-06-21 14:10:06.000000000 +1000 @@ -183,8 +183,13 @@ static void summarize_posix_acl(struct posix_acl *acl, struct posix_acl_summary *pas) { struct posix_acl_entry *pa, *pe; - pas->users = 0; - pas->groups = 0; + + /* + * Only pas.users and pas.groups need initialization; previous + * posix_acl_valid() calls ensure that the other fields will be + * initialized in the following loop. But, just to placate gcc: + */ + memset(pas, 0, sizeof(*pas)); pas->mask = 07; pe = acl->a_entries + acl->a_count; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |