![]() | |||||||||||||
Messages in this thread |
Hi Keiichi, On 6/19/07, Keiichi KII <k-keiichi@bx.jp.nec.com> wrote: > Hello Satyam, > > > Sorry, but we're not covering from the error condition fully here. Note > > that later you merge the temporary modify_target_list entirely back > > into the target_list ... which would still contain these erroneous > > nodes. A full cleanup (kobject_unregister the entry, and then list_del > > from modify_target_list) is required here, before continuing. > > I will fix this. If the error occurs, I think so that we need to cleanup > completely. Yes, thanks. > >> + strcpy(nt->np.dev_name, dev->name); > > > > ... you'll have move this up. > > > > Why? I don't have opposition about moving this up, but I'm misplacing the abobe code? > or it isn't appropriate about coding style? As I said, _either_ you stick a "continue;" after recovering from the error above this code (i.e. if the sysfs_create_link() just above this line fails), _or_ you'll have to move the strcpy() up (above the sysfs_create_link). Note that recovering fully would mean unregistering the kobject for that target, deleting the node from the modify_list and kfree'ing the struct netconsole_target *nt (otherwise we'll have a memory leak on our hands). And if we've kfree'd nt, we'll oops on trying to dereference it like we're doing in the strcpy here. Thanks, Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-06-19 16:23 [from the cache] ©2003-2008 | |||||||||||||