| Date | Mon, 18 Jun 2007 06:52:44 +0200 | From | Sam Ravnborg <> | Subject | Re: [-mm patch] arch/i386/video/fbdev.c should #include <asm/fb.h> |
| |
On Mon, Jun 18, 2007 at 01:42:57AM +0200, Adrian Bunk wrote: > Every file should include the headers containing the prototypes for > it's global functions. > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- > --- linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c.old 2007-06-17 15:48:25.000000000 +0200 > +++ linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c 2007-06-17 15:48:53.000000000 +0200 > @@ -11,6 +11,8 @@ > #include <linux/fb.h> > #include <linux/pci.h> > > +#include <asm/fb.h> > +
1) Why not include asm/fb.h from linux/fb.h? 2) Is asm/fb.h an -mm thing? I do not have it in my linus tree.
Note: Ketchup is broken on my ubuntu box so no -mm right now.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|