lkml.org 
[lkml]   [2007]   [Jun]   [18]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
FromMike Frysinger <>
SubjectRe: [patch] make hdrscheck.sh force __asm__ in exported headers
DateMon, 18 Jun 2007 01:54:41 -0400
On Monday 18 June 2007, Andrew Morton wrote:
> Also, your changelog sucks:
>
>   This updates scripts/hdrschecks.sh by grepping for asm() constructs and
>   rejecting them in favor of __asm__() in exported headers.
>
> well OK.  But for what reason?  We can see a lot of pain in this patch but
> no gain.  The changelog should tell us what the benefit is, so we can make
> informed tradeoff decisions.

err, should have included the rationale in previous e-mail ...

we want to audit asm/volatile because both constructs will fail in userland 
builds when GNU extensions are turned off (like -std=c99) ... __asm__ and 
__volatile__ will work in both places.
-mike
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-06-18 07:57    [from the cache]
©2003-2008