lkml.org 
[lkml]   [2007]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectmsleep(1000) vs. schedule_timeout_uninterruptible(HZ+1)
I was looking at some of the stupider code that calls msleep(),
particularly that which does
msleep(jiffies_to_msecs(jiff))

and I noticed that msleep() just calls schedule_timeout_uninterruptible().
But it does it in a loop.

The basic question is, when does the loop make a difference?
Is it only when you're on a wait queue? Or are there other kinds of
unexpected wakeups that can arrive?

I see all kinds of uses of both kinds for simple "wait a while" operations,
and I'm not sure if one is more correct than the other.

(And, in drivers/media/video/cpia2/cpia2_v4l.c:cpia2_exit(), a lovely
example of calling schedule_timeout() without set_current_state() first.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-17 18:17    [W:0.147 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site