lkml.org 
[lkml]   [2007]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch] Reporting the lid status using INPUT
    Date
    On Saturday 16 June 2007 13:11, Richard Hughes wrote:
    > On Fri, 2007-06-15 at 15:53 +0100, Richard Hughes wrote:
    > > On Fri, 2007-06-15 at 10:29 -0400, Dmitry Torokhov wrote:
    > > > On 6/15/07, Richard Hughes <hughsient@gmail.com> wrote:
    > > > > On Fri, 2007-06-15 at 13:29 +0100, Richard Hughes wrote:
    > > > > > in response to an event, but I'm thinking in a resume hook we should
    > > > > > probably do acpi_evaluate_integer(handle, "_LID", NULL, &state) and then
    > > > > > send an event, just so userspace is aware of what the state of the panel
    > > > > > is.
    > > > >
    > > > > Attached patch fixed the issue for me. Comments?
    > > > >
    > > >
    > > > The patch makes perfect sense. The only issue I have is this:
    > > >
    > > > > + /* on resume we send the state; it might be the same, but userspace
    > > > > + * should handle duplicated events */
    > > >
    > > > If switch state matches to what input layer thinks it is the event
    > > > will not even reach userspace.
    > >
    > > Okay, new patch attached, thanks for the speedy review.
    >
    > This fix is also confirmed by somebody else, see
    > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243030
    >
    > It would be great if this could go into .22, although I appreciate it's
    > quite late in the day.
    >

    This is of course Len's call but in my book this is a bugfix and as such
    is appropriate for -rc4/rc5.

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-16 19:55    [W:0.047 / U:120.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site