lkml.org 
[lkml]   [2007]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] natsemi irq flags
    On 06/15/2007 05:17 PM, Gregory Haskins wrote:
    > The spinlock irq flags should be a unsigned long to properly support 64 bit

    Ouch. Can't we automate checking for that?

    >
    > Signed-off-by: Gregory Haskins <ghaskins@novell.com>
    >
    > ---
    >
    > drivers/net/natsemi.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
    > index 4cf0d3f..460a087 100644
    > --- a/drivers/net/natsemi.c
    > +++ b/drivers/net/natsemi.c
    > @@ -690,7 +690,7 @@ static ssize_t natsemi_set_dspcfg_workaround(struct device *dev,
    > {
    > struct netdev_private *np = netdev_priv(to_net_dev(dev));
    > int new_setting;
    > - u32 flags;
    > + unsigned long flags;
    >
    > /* Find out the new setting */
    > if (!strncmp("on", buf, count - 1) || !strncmp("1", buf, count - 1))
    >
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-16 00:09    [W:0.020 / U:61.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site