Messages in this thread | | | From | Uli Luckas <> | Subject | Re: [PATCH -mm 2/2] PM: Disable usermode helper before hibernation and suspend | Date | Fri, 15 Jun 2007 15:08:52 +0200 |
| |
On Monday, 4. June 2007, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rjw@sisk.pl> > > Use a hibernation and suspend notifier to disable the user mode helper > before a hibernation/suspend and enable it after the operation. > Hi Rafael, I have a couple of questions, regarding this patch ... > - if (!khelper_wq) > + if (!khelper_wq || usermodehelper_disabled) > return -EBUSY; 1) how about not returning -EBUSY here, if (wait == UMH_NO_WAIT)? 2) how does your patch prevent wait_for_completion(&done) to hang during freezing if usermodehelper_pm_callback is called _after_ the above check?
Regards Uli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |