lkml.org 
[lkml]   [2007]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch] sched: fix SysRq-N (normalize RT tasks)
    Date
    Ingo Molnar <mingo@elte.hu> writes:

    > From: Ingo Molnar <mingo@elte.hu>
    > Subject: [patch] sched: fix SysRq-N (normalize RT tasks)
    >
    > Gene Heskett reported the following problem while testing CFS: SysRq-N
    > is not always effective in normalizing tasks back to SCHED_OTHER.
    >
    > the reason for that turns out to be the following bug:
    > normalize_rt_tasks() uses for_each_process() to iterate through all
    > tasks in the system. The problem is, this method does not iterate
    > through all tasks, it iterates through all thread groups. The proper
    > mechanism to enumerate all tasks is to use a do_each_thread() +
    > while_each_thread() loop.

    Was this always a bug or did the meaning of for_each_process() change
    since this code was added?

    --
    Måns Rullgård
    mans@mansr.com

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-14 21:13    [W:0.479 / U:59.460 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site