Messages in this thread | | | Date | Wed, 13 Jun 2007 11:07:01 +0800 | From | Fengguang Wu <> | Subject | Re: [PATCH 4/9] readahead: data structure and routines |
| |
Hi Rusty,
On Wed, Jun 13, 2007 at 10:27:19AM +1000, Rusty Russell wrote: > On Tue, 2007-06-12 at 20:07 +0800, Fengguang Wu wrote: > > or preferably: > > > > pgoff_t start; /* where readahead started */ > > unsigned long size; /* # of readahead pages */ > > unsigned long async_size; /* do asynchronous readahead when there are only # of pages ahead */ > > > > unsigned long async_size_old; /* TODO: this one is not needed for now */ > > > > Any opinions? Thanks. > > These names and comments are really nice. I think the code will become > more readable after this, too.
Thank you!
> Did you want me to try to make this patch, or did you want to do it?
I'll make it, after your patch, hehe.
Fengguang
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |