lkml.org 
[lkml]   [2007]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/9] readahead: data structure and routines
From
Date
On Tue, 2007-06-12 at 20:07 +0800, Fengguang Wu wrote:
> Hi Rusty,

Hi Fengguang,

> or preferably:
>
> pgoff_t start; /* where readahead started */
> unsigned long size; /* # of readahead pages */
> unsigned long async_size; /* do asynchronous readahead when there are only # of pages ahead */
>
> unsigned long async_size_old; /* TODO: this one is not needed for now */
>
> Any opinions? Thanks.

These names and comments are really nice. I think the code will become
more readable after this, too.

Did you want me to try to make this patch, or did you want to do it?

Thanks,
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-13 02:31    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site