lkml.org 
[lkml]   [2007]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: fix improper .init-type section references
    On Tue, Jun 12, 2007 at 07:39:30PM +0530, Satyam Sharma wrote:
    > On 6/12/07, Jan Beulich <jbeulich@novell.com> wrote:
    > >>> And from a purely theoretical
    > >>> perspective I don't think such references should be considered bad -
    > >>> .exit.* should be discarded together with .init.* if unloading is
    > >>> impossible (built-in or configured off), not before module/kernel
    > >>> initialization.
    > >>
    > >>Hmm, but that's not how things are, presently. __exit marked
    > >>functions are simply not linked into the kernel (when that module
    > >>is being built-in) at all -- this "discard" happens at _build time_
    > >>(to save on kernel image size).
    > >
    > >Not really, at least not for i386 and x86-64 - see their vmlinux.lds.S
    > >files.
    >
    > For those archs, yes, you're right that modpost should be
    > special-casing (based on arch) before complaining for
    > .init -> .exit references.
    No.
    References from __init to __exit is wrong independent on architecture.
    powerpc discards them at buildtime, i386 at runtime.
    So for the latter we will have an oops where we for the first have a build
    time failure.
    It is better to let modpost warn always - independent on architecture.

    Sam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-06-12 20:01    [W:2.825 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site