[lkml]   [2007]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] fix improper .init-type section references
On 6/12/07, Satyam Sharma <> wrote:
> On 6/12/07, Jan Beulich <> wrote:
> [...]
> > >I believe the correct fix to silence modpost here would be to mark its
> > >caller kthreadd() also as __init, because it too is used only at init time?
> >
> > I don't think so - it is my understanding that this is the body of a thread
> > that never dies.
> Ugh, yes, I'm smoking God-knows-what, and you're absolutely correct!
> So we should be marking kthreadd() as __init_refok instead, it seems.

Actually, kthreadd_setup() is a 4-liner with only one callsite. Not much
point marking it as __init. In fact, does it even need to be a separate
function at all? We could just get rid of kthreadd_setup() and open-code
those 4 lines in kthreadd() itself ...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-06-12 13:31    [W:0.032 / U:0.936 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site