lkml.org 
[lkml]   [2007]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [shm][hugetlb] Fix get_policy for stacked shared memory files
Date

> Can we just double-check the refcounting please?
>
> > index 4fefbad..8d2672d 100644
> > --- a/ipc/shm.c
> > +++ b/ipc/shm.c
> > @@ -254,8 +254,10 @@ struct mempolicy *shm_get_policy(struct vm_area_struct *vma, unsigned long addr)
> >
> > if (sfd->vm_ops->get_policy)
> > pol = sfd->vm_ops->get_policy(vma, addr);
>
> afacit this takes a ref on the underlying policy
>
> > - else
> > + else if (vma->vm_policy)
> > pol = vma->vm_policy;
> > + else
> > + pol = current->mempolicy;
>
> but these two do not.
>
> > return pol;
> > }
> > #endif
>
> Is is all correct?

No it looks broken.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-12 12:23    [W:0.150 / U:1.256 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site