lkml.org 
[lkml]   [2007]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: fix oops on cat /dev/snapshot
Date
On Monday, 11 June 2007 14:17, Pavel Machek wrote:
> What /dev/snapshot is simply cat-ed -- without ioctls used in normal
> operation -- it oopses. This one should fix it.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> --- clean-mm/kernel/power/user.c 2007-06-09 16:18:12.000000000 +0200
> +++ linux-mm/kernel/power/user.c 2007-06-11 14:06:19.000000000 +0200
> @@ -99,6 +99,8 @@
> ssize_t res;
>
> data = filp->private_data;
> + if (!data->ready)
> + return -EINVAL;

I'd like to use -ENODATA here.

> res = snapshot_read_next(&data->handle, count);
> if (res > 0) {
> if (copy_to_user(buf, data_of(data->handle), res))
>

I have a patch for that and I'm going to post it in a while if you don't
mind.

I've already posted it once, here: http://lkml.org/lkml/2007/6/10/146

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-06-11 16:33    [W:0.038 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site