Messages in this thread | | | Date | Sun, 10 Jun 2007 12:11:55 +0200 | From | Pavel Machek <> | Subject | Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices |
| |
Hi!
> > My other concerns with this patch are that it exports incorrect > > information on spitz (which I had warned about and I will get bug > > reports about) and that "description" is not really a suitable name for > > a sysfs attribute, "function" might give a better idea of what it > > represents to developers. > > > > I still question whether either colour or function properties are > > actually particularly useful to userspace other than for naming purposes > > which is why they were part of the device name. > > > > Anyhow, I'm trying not to say too much more as it will just go in > > circles. I'll await a reply from Greg. > > Hm, I thought I made my opinion pretty clear in the beginning. > > Why not just do a simple: > led01 > led02 > led03 > ... > > and so on? > > And use the 'name' field to put the name of your device (disk, > bluetooth, etc.) This is the way all other busses and devices work, and > I don't think that LEDs are anything more "special" than anything else > in the kernel, right?
Can we keep the original naming? spitz:disk is as unique as led02, and it is _way_ easier to use.
Come on, I want to use the led subsystem from the scripts... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |