Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [patch-mm 06/23] clockevents: Fix resume logic | Date | Sun, 10 Jun 2007 18:34:19 +0200 |
| |
On Sunday, 10 June 2007 15:17, Thomas Gleixner wrote: > On Sun, 2007-06-10 at 12:58 +0200, Rafael J. Wysocki wrote: > > > > This is the resume part, or at least it seems so, but the above one is a > > suspend callback. If I understand it correctly, this one replaces > > hpet_resume(), but is it sufficient for the suspend part too? > > Oops. Sorry, misunderstood you. Yeah, it's intentional. It gets reset on > power off and we have not seen any problems with this yet.
OK, I wouldn't do it in this patch, though.
IMO it's a bit more than the changelog says and we'll lose the track record of this change if it goes like this. Would that be possible to separate it?
Greetings, Rafael
-- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |