Messages in this thread | | | Date | Fri, 1 Jun 2007 17:16:12 -0700 | From | Andrew Morton <> | Subject | Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning |
| |
On Fri, 1 Jun 2007 16:57:20 -0700 (PDT) Linus Torvalds <torvalds@linux-foundation.org> wrote:
> Andrew, want to take this patch to -mm to see if it triggers anything?
spose so.
I think it'd be better if we kept the WARN_ON_ONCE(size == 0) in there, because it is exposing some coding warts. But we should turn it off for 2.6.22 and make it conditional on CONFIG_DEVEL_KERNEL (or whatever it will be called) later.
The BADPTR thing is a little worrying because it will make previously-working-by-luck code go oops. I guess we can live with that.
So we end up with the BADPTR code enabled even in production kernels, in which case your ((unsigned long)x <= 16) trick is worth doing.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |