Messages in this thread | | | Date | Fri, 1 Jun 2007 15:17:03 -0400 (EDT) | From | Byron Stanoszek <> | Subject | Re: [PATCH] Introduce O_CLOEXEC (take >2) |
| |
On Thu, 31 May 2007, Kyle McMartin wrote:
> On Fri, Jun 01, 2007 at 11:38:40AM +1000, Stephen Rothwell wrote: >> This also breaks Alpha (which uses 02000000 for O_DIRECT) and parisc >> (which uses 02000000 for O_RSYNC). So you ether need to choose a >> different value or define O_CLOEXEC for those two architectures. >> > > That's easy enough to fix... > > Signed-off-by: Kyle McMartin <kyle@parisc-linux.org> > > diff --git a/include/asm-parisc/fcntl.h b/include/asm-parisc/fcntl.h > index 317851f..4ca0fb0 100644 > --- a/include/asm-parisc/fcntl.h > +++ b/include/asm-parisc/fcntl.h > @@ -14,6 +14,7 @@ > #define O_DSYNC 01000000 /* HPUX only */ > #define O_RSYNC 02000000 /* HPUX only */ > #define O_NOATIME 04000000 > +#define O_CLOEXEC 08000000 /* set close_on_exec */ > > #define O_DIRECTORY 00010000 /* must be a directory */ > #define O_NOFOLLOW 00000200 /* don't follow links */
These are octal values, so you really want to use 010000000 instead of 08000000. :-)
While looking at that file further, I noticed these two flags share the same value. I don't know DMAPI/XDSM, but could they potentially conflict?
#define O_NOATIME 04000000 #define O_INVISIBLE 04000000 /* invisible I/O, for DMAPI/XDSM */
Regards, -Byron
-- Byron Stanoszek Ph: (330) 644-3059 Systems Programmer Fax: (330) 644-8110 Commercial Timesharing Inc. Email: byron@comtime.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |