Messages in this thread | | | Date | Wed, 09 May 2007 20:17:28 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] sata_nv: fix ADMA freeze/thaw/irq_clear issues |
| |
Robert Hancock wrote: > This patch fixes some problems with ADMA-capable controllers with regard > to freeze, > thaw and irq_clear libata callbacks. Freeze and thaw didn't switch the > ADMA-specific > interrupts on or off, and more critically the irq_clear function didn't > respect > the restriction that the notifier clear registers for both ports have to > be written > at the same time even when only one port is being cleared. This could > result in > timeouts on one port when error handling (i.e. as a result of hotplug) > occurred on the other port. > > As well, this fixes some issues in the interrupt handler: we shouldn't > check any > ADMA status if the port has ADMA switched off because of an ATAPI > device, and > it also checks to see if any ADMA interrupt has been raised even when we > are in > port-register mode. > > Signed-off-by: Robert Hancock <hancockr@shaw.ca>
applied
please properly word-wrap your patch descriptions in the future
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |