lkml.org 
[lkml]   [2007]   [May]   [9]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    DateWed, 9 May 2007 00:02:00 -0700
    From"H. Peter Anvin" <>
    Subject[PATCH] i386: cpu/transmeta.c: fix definition of USER686
    The definition of USER686 is supposed to be a mask of feature bits,
    not an OR of feature numbers!  It happened to work anyway on the only
    processor affected, simply by pure coincidence.  Fix.
    
    Signed-off-by: H. Peter Anvin <hpa@zytor.com>
    ---
     arch/i386/kernel/cpu/transmeta.c |    6 ++++--
     1 files changed, 4 insertions(+), 2 deletions(-)
    diff --git a/arch/i386/kernel/cpu/transmeta.c b/arch/i386/kernel/cpu/transmeta.c
    index 6471a5a..200fb3f 100644
    --- a/arch/i386/kernel/cpu/transmeta.c
    +++ b/arch/i386/kernel/cpu/transmeta.c
    @@ -77,8 +77,10 @@ static void __cpuinit init_transmeta(struct cpuinfo_x86 *c)
     	set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability);
     	
     	/* If we can run i686 user-space code, call us an i686 */
    -#define USER686 (X86_FEATURE_TSC|X86_FEATURE_CX8|X86_FEATURE_CMOV)
    -        if ( c->x86 == 5 && (c->x86_capability[0] & USER686) == USER686 )
    +#define USER686 ((1 << X86_FEATURE_TSC)|\
    +		 (1 << X86_FEATURE_CX8)|\
    +		 (1 << X86_FEATURE_CMOV))
    +        if (c->x86 == 5 && (c->x86_capability[0] & USER686) == USER686)
     		c->x86 = 6;
     
     #ifdef CONFIG_SYSCTL
    -- 
    1.5.1.3
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2007-05-09 09:05    [from the cache]
    ©2003-2008