lkml.org 
[lkml]   [2007]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -mm] PM: Separate hibernation code from suspend code
FromJohannes Berg <>
DateTue, 08 May 2007 10:41:36 +0200
On Mon, 2007-05-07 at 23:35 +0200, Rafael J. Wysocki wrote:

> > Also, you could then simplify all the instances of
> > (hibernation_mode == HIBERNATION_PLATFORM && hibernation_ops)
> > to just
> > (hibernation_mode == HIBERNATION_PLATFORM)
> > in various if statements and other places.
>
> No, that's not a good idea, because of the "reduce code duplication patch"
> that I'd like to go on top of this. I'd rather use 'if (hibernation_ops)' here. :-)

But if you want the user to be able to change away from 'platform' mode
you still have to have
if (hibernation_ops && hibernation_mode == HIBERNATION_PLATFORM)
in most places, no?
johannes
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-05-08 10:43    [from the cache]
©2003-2010