lkml.org 
[lkml]   [2007]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [rfc] optimise unlock_page
    On Tue, May 08, 2007 at 01:13:35PM +0100, David Howells wrote:
    >
    > Nick Piggin <npiggin@suse.de> wrote:
    >
    > > This patch trades a page flag for a significant improvement in the unlock_page
    > > fastpath. Various problems in the previous version were spotted by Hugh and
    > > Ben (and fixed in this one).
    >
    > It looks reasonable at first glance, though it does consume yet another page
    > flag:-/ However, I think that's probably a worthy trade.

    Well, that's the big question :)


    > > }
    > > -
    > > +
    > > +static inline void unlock_page(struct page *page)
    > > +{
    > > + VM_BUG_ON(!PageLocked(page));
    > > + ClearPageLocked_Unlock(page);
    > > + if (unlikely(PageWaiters(page)))
    > > + __unlock_page(page);
    > > +}
    > > +
    >
    > Please don't simply discard the documentation, we have little enough as it is:

    Oops, right.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-09 00:39    [W:0.021 / U:88.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site