Messages in this thread | | | Date | Wed, 9 May 2007 00:35:18 +0200 | From | Nick Piggin <> | Subject | Re: [rfc] optimise unlock_page |
| |
On Tue, May 08, 2007 at 01:13:35PM +0100, David Howells wrote: > > Nick Piggin <npiggin@suse.de> wrote: > > > This patch trades a page flag for a significant improvement in the unlock_page > > fastpath. Various problems in the previous version were spotted by Hugh and > > Ben (and fixed in this one). > > It looks reasonable at first glance, though it does consume yet another page > flag:-/ However, I think that's probably a worthy trade.
Well, that's the big question :)
> > } > > - > > + > > +static inline void unlock_page(struct page *page) > > +{ > > + VM_BUG_ON(!PageLocked(page)); > > + ClearPageLocked_Unlock(page); > > + if (unlikely(PageWaiters(page))) > > + __unlock_page(page); > > +} > > + > > Please don't simply discard the documentation, we have little enough as it is:
Oops, right.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |