Messages in this thread Patch in this message | | | Date | Tue, 8 May 2007 22:16:38 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] drivers/macintosh: remove default y from Kconfig (was: Re: 2.6.21-mm1) |
| |
On Tue, May 08, 2007 at 10:33:22AM +0200, Jan Engelhardt wrote: > > On May 7 2007 12:35, Borislav Petkov wrote: > > > >I don't think I need macintosh drivers for my x86 arch selected in by default, > > do I? > > For new config variables that were introduced, I set them to 'default y' > so when upgrading from an older .config, it does not deselect the drivers > _inside_ the new menuconfig. People who have CONFIG_MAC_EMUMOUSEBTN=y > will magically get it set to =n because MACINTOSH_DRIVERS is not y. I had a similar suspicion that something else requires the default=y things ...
> Whether you need macintosh on i386... oh well, ask someone who knows. > Fact is, that at least SUSE has CONFIG_MAC_EMUMOUSEBTN=y but I > wonder wtf for.
Well, this is clearly wrong since it is only for a mac, single-button, mouse, IMHO. Look for CONFIG_MAC_EMUMOUSEBTN in drivers/char/keyboard.c
> >Index: trees/linux-mm/drivers/macintosh/Kconfig > >=================================================================== > >--- linux-mm.orig/drivers/macintosh/Kconfig > >+++ linux-mm/drivers/macintosh/Kconfig > >@@ -2,7 +2,6 @@ > > menuconfig MACINTOSH_DRIVERS > > bool "Macintosh device drivers" > > depends on PPC || MAC || X86 > >- default y > > How about > default y if PPC || MAC > then?
sounds good, here we go:
----- From: Borislav Petkov <bbpetkov@yahoo.de>
Do not select macintosh drivers by default.
Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
-- Index: linux-mm/drivers/macintosh/Kconfig =================================================================== --- linux-mm/drivers/macintosh/Kconfig.orig +++ linux-mm/drivers/macintosh/Kconfig @@ -2,7 +2,7 @@ menuconfig MACINTOSH_DRIVERS bool "Macintosh device drivers" depends on PPC || MAC || X86 - default y + default y if PPC || MAC
if MACINTOSH_DRIVERS
-- Regards/Gruß, Boris. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |