Messages in this thread | | | Subject | Re: [PATCH] Intel IXP4xx network drivers v.2 - NPE | From | Krzysztof Halasa <> | Date | Tue, 08 May 2007 15:56:20 +0200 |
| |
Michael-Luke Jones <mlj28@cam.ac.uk> writes:
> Already in mach-ixp4xx, so can just be called npe.c
I want ixp4xx_ prefix in module name, otherwise I'd call it npe.c, sure.
> Debugging code? Can this go?
Why? Especially with code having to work with third party binary-only firmware? Suicide. They are eliminated at build time = performance hit (OTOH this file isn't on any fast path).
> It may be a matter of taste, but could some of the many definitions > at the top of ixp4xx_npe.c go in the header file here?
It's actually not only a matter of taste, they are private to the .c file and I don't want to make them available to the public (but sure, I don't like them in .c either, I think nobody likes such definitions anywhere but they have to exist somewhere). -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |