Messages in this thread | | | Date | Sun, 6 May 2007 12:11:24 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2] fs: Fix indentation in do_path_lookup |
| |
On Sat, May 05, 2007 at 06:59:39PM -0400, Josef 'Jeff' Sipek wrote: > Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu> > --- > fs/namei.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/namei.c b/fs/namei.c > index 0262594..600a4e7 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -1159,7 +1159,7 @@ out: > if (likely(retval == 0)) { > if (unlikely(!audit_dummy_context() && nd && nd->dentry && > nd->dentry->d_inode)) > - audit_inode(name, nd->dentry->d_inode); > + audit_inode(name, nd->dentry->d_inode); > }
Actually this area should get some more changes. There should be no likely retval == 0 branch because it only contains another branch, and nd is guaranteed to be zero.
So it should become:
if (unlikely(!retval && !audit_dummy_context() && nd->dentry && nd->dentry->d_inode)) audit_inode(name, nd->dentry->d_inode);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |