Messages in this thread Patch in this message | | | From | NeilBrown <> | Date | Mon, 7 May 2007 10:35:15 +1000 | Subject | [PATCH 001 of 8] knfsd: Avoid use of unitialised variables on error path when nfs exports. |
| |
We need to zero various parts of 'exp' before any 'goto out', otherwise when we go to free the contents... we die.
Signed-off-by: Neil Brown <neilb@suse.de> Cc: stable@kernel.org
### Diffstat output ./fs/nfsd/export.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff .prev/fs/nfsd/export.c ./fs/nfsd/export.c --- .prev/fs/nfsd/export.c 2007-05-07 10:30:16.000000000 +1000 +++ ./fs/nfsd/export.c 2007-05-07 10:30:28.000000000 +1000 @@ -469,6 +469,13 @@ static int svc_export_parse(struct cache nd.dentry = NULL; exp.ex_path = NULL; + /* fs locations */ + exp.ex_fslocs.locations = NULL; + exp.ex_fslocs.locations_count = 0; + exp.ex_fslocs.migrated = 0; + + exp.ex_uuid = NULL; + if (mesg[mlen-1] != '\n') return -EINVAL; mesg[mlen-1] = 0; @@ -509,13 +516,6 @@ static int svc_export_parse(struct cache if (exp.h.expiry_time == 0) goto out; - /* fs locations */ - exp.ex_fslocs.locations = NULL; - exp.ex_fslocs.locations_count = 0; - exp.ex_fslocs.migrated = 0; - - exp.ex_uuid = NULL; - /* flags */ err = get_int(&mesg, &an_int); if (err == -ENOENT) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |