lkml.org 
[lkml]   [2007]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 1/3] SLUB: slab_ops instead of constructors / destructors
    On 5/5/07, clameter@sgi.com <clameter@sgi.com> wrote:
    > This patch gets rid constructors and destructors and replaces them
    > with a slab operations structure that is passed into SLUB.

    Looks good to me.

    On 5/5/07, clameter@sgi.com <clameter@sgi.com> wrote:
    > +struct slab_ops {
    > + /* FIXME: ctor should only take the object as an argument. */
    > + void (*ctor)(void *, struct kmem_cache *, unsigned long);
    > + /* FIXME: Remove all destructors ? */
    > + void (*dtor)(void *, struct kmem_cache *, unsigned long);
    > +};

    For consistency with other operations structures, can we make this
    struct kmem_cache_operations or kmem_cache_ops, please?
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-05 17:47    [W:0.020 / U:1.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site