Messages in this thread | | | Date | Sun, 6 May 2007 03:27:47 +0400 | From | Vitaly Bordug <> | Subject | Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support |
| |
On Fri, 4 May 2007 12:35:43 -0700 Andrew Morton wrote:
> On Fri, 04 May 2007 03:57:51 +0400 > Vitaly Bordug <vitb@kernel.crashing.org> wrote: > > > > > Adds support for PowerQuicc on-chip PCMCIA. The driver is > > implemented as of_device, so only arch/powerpc stuff is capable to > > use it, which now implies only mpc885ads reference board. > > > > To cope with the code that should be hooked inside driver, but is > > really board specific (like set_voltage), global structure > > mpc8xx_pcmcia_ops holds necessary function pointers that are filled > > in the BSP code. > > > > argh. > > akpm:/home/akpm> grep '^.* ' x | wc -l > 72 > > please, Linux uses hard-tabs, not > spacespacespacespacespacespacespacespace everywhere. >
Whoops. That must've survived being copypasted from the original m8xx_pcmcia.c. That reminds me to do Lindent on the affected sources but that is subject for another patch. Sorry for the hassle.
Apparently all the issues were correct, and I'll follow-up with the reworked patch. Thanks for looking at it.
-- Sincerely, Vitaly
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |