lkml.org 
[lkml]   [2007]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug]
    From
    Date
    On Sat, 2007-05-05 at 18:58 +0200, Antonino Ingargiola wrote:
    > This patch does not solve the problem with the cdc_acd driver. I still
    > need to flush two times to really flush the input. And the "secondary
    > buffer" still seems 26 bytes (as before).

    I missed a bit, try this.

    --- a/drivers/usb/class/cdc-acm.c 2007-04-25 22:08:32.000000000 -0500
    +++ b/drivers/usb/class/cdc-acm.c 2007-05-05 12:03:19.000000000 -0500
    @@ -335,8 +335,6 @@ static void acm_rx_tasklet(unsigned long
    spin_lock_irqsave(&acm->throttle_lock, flags);
    throttled = acm->throttle;
    spin_unlock_irqrestore(&acm->throttle_lock, flags);
    - if (throttled)
    - return;

    next_buffer:
    spin_lock_irqsave(&acm->read_lock, flags);
    @@ -355,18 +353,9 @@ next_buffer:
    spin_lock_irqsave(&acm->throttle_lock, flags);
    throttled = acm->throttle;
    spin_unlock_irqrestore(&acm->throttle_lock, flags);
    - if (!throttled)
    - tty_insert_flip_string(tty, buf->base, buf->size);
    + tty_insert_flip_string(tty, buf->base, buf->size);
    tty_flip_buffer_push(tty);

    - if (throttled) {
    - dbg("Throttling noticed");
    - spin_lock_irqsave(&acm->read_lock, flags);
    - list_add(&buf->list, &acm->filled_read_bufs);
    - spin_unlock_irqrestore(&acm->read_lock, flags);
    - return;
    - }
    -
    spin_lock_irqsave(&acm->read_lock, flags);
    list_add(&buf->list, &acm->spare_read_bufs);
    spin_unlock_irqrestore(&acm->read_lock, flags);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-05 19:09    [W:0.047 / U:3.640 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site