lkml.org 
[lkml]   [2007]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Remove constructor from buffer_head
On Thu, 3 May 2007 20:34:48 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:

> On Thu, 3 May 2007, Andrew Morton wrote:
>
> > On Thu, 3 May 2007 20:08:41 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> >
> > > Performance tests show a slight improvements in netperf (not a
> > > strong case for a performance improvement but removing the
> > > constructor has definitely no negative impact so why keep
> > > this around?).
> > >
> > > TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to localhost (127.0.0.1) port 0 AF_INET
> > > Recv Send Send
> > > Socket Socket Message Elapsed
> > > Size Size Size Time Throughput
> > > bytes bytes bytes secs. 10^6bits/sec
> > >
> > > Before:
> > > 87380 16384 16384 10.01 6026.04
> > > 87380 16384 16384 10.01 5992.17
> > > 87380 16384 16384 10.01 6071.23
> > >
> > > After:
> > > 87380 16384 16384 10.01 6090.20
> > > 87380 16384 16384 10.01 6078.3
> > > 87380 16384 16384 10.00 6013.52
> >
> > How could a filesystem change affect networking performance?
> >
> > The change looks nice, but I'd microbenchmark it with a write-to-ext2-on-ramdisk
> > or something like that.
>
> Hmmmm.. I was told in another thread that this is the most frequently used
> slab for this benchmark

That would be hair-raising ;) I suspect confusion with sk_buff.

buffer_heads do get used quite a bit though. A good microbenchmark would
be to sit in a tight loop extending and truncating an ext2 file

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-04 06:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site