lkml.org 
[lkml]   [2007]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[patch]clarification of coding style regarding conditional statements with two branches
Date
Hi,

I suggest that the coding style should state that if either branch of
an 'if' statement needs braces, both branches should use them.

Regards
Oliver
Signed-off-by: Oliver Neukum <oneukum@suse.de>
----

--- a/Documentation/CodingStyle 2007-04-20 13:08:17.000000000 +0200
+++ b/Documentation/CodingStyle 2007-04-20 13:16:14.000000000 +0200
@@ -160,6 +160,21 @@
25-line terminal screens here), you have more empty lines to put
comments on.

+Do not unnecessarily use braces where a single statement will do.
+
+if (condition)
+ action();
+
+This does not apply if one branch of a conditional statement is a single
+statement. Use braces in both branches.
+
+if (condition) {
+ do_this();
+ do_that();
+} else {
+ otherwise();
+}
+
3.1: Spaces

Linux kernel style for use of spaces depends (mostly) on
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-05-04 09:29    [W:0.051 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site