lkml.org 
[lkml]   [2007]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm] PM: Separate hibernation code from suspend code
Trivial suggestions:

On 5/4/07, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> --- linux-2.6.21.orig/include/linux/suspend.h 2007-05-02 22:08:58.000000000 +0200
> +++ linux-2.6.21/include/linux/suspend.h 2007-05-03 15:22:24.000000000 +0200
> [...]
> +/**
> + * hibernation_set_ops - set the global hibernate operations
> + * @ops: the hibernation operations to use in subsequent hibernation transitions
> + */
> +extern void hibernation_set_ops(struct hibernation_ops *ops);

Comment must go near code, not with prototype in header.

> +/**
> + * hibernate - hibernate the system
> + */
> +extern int hibernate(void);

Pointless comment. You've already written a doc-book comment in the
code for this function anyway, so could just as well remove this.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-04 19:25    [W:0.452 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site