Messages in this thread | | | Date | Fri, 1 Jun 2007 11:38:40 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH] Introduce O_CLOEXEC (take >2) |
| |
On Thu, 31 May 2007 16:20:21 -0700 Andrew Morton <akpm@linux-foundation.org> wrote: > > > diff --git a/include/asm-generic/fcntl.h b/include/asm-generic/fcntl.h > > index c154b9d..b847741 100644 > > --- a/include/asm-generic/fcntl.h > > +++ b/include/asm-generic/fcntl.h > > @@ -48,6 +48,9 @@ > > #ifndef O_NOATIME > > #define O_NOATIME 01000000 > > #endif > > +#ifndef O_CLOEXEC > > +#define O_CLOEXEC 02000000 /* set close_on_exec */ > > +#endif > > #ifndef O_NDELAY > > #define O_NDELAY O_NONBLOCK > > #endif > > This will break xtensa, because that architecture (and only that > architecture) doesn't include asm-generic/fcntl.h from asm/fcntl.h.
This also breaks Alpha (which uses 02000000 for O_DIRECT) and parisc (which uses 02000000 for O_RSYNC). So you ether need to choose a different value or define O_CLOEXEC for those two architectures.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |