lkml.org 
[lkml]   [2007]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 8/9] F00F bug fixup for i386 - use conditional calls
    On Thu, 31 May 2007 17:07:55 -0400
    Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

    > * Andrew Morton (akpm@linux-foundation.org) wrote:
    >
    > > > Use the faster conditional calls for F00F bug handling in do_page_fault.
    > > >
    > >
    > > I guess this means that CONDCALL will be enabled on pretty much all i386,
    > > in which case making the whole feature Kconfigurable is starting to look
    > > marginal.
    > >
    > > Perhaps a better approach would have to made this change dependent upon
    > > CONDCALL, rather than forcing it on.
    > >
    >
    > Do you mean making X86_F00F_BUG depend on COND_CALL instead of selecting
    > it ?

    yup

    > > > + if (cond_call(fix_f00f, do_f00f_workaround(regs, address)))
    > > > + return;
    > >
    > > We do a cond_call() to an inlined function? That's a bit weird, isn't it?
    > >
    >
    > Yes, but it works :) I will add this information to the documentation.

    But why does it work? Did the compiler generate an out-of-line copy
    of the function? If so, we'll end up with multiple copies of the function if
    there are other callers. If not, the `inline' was pointless.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-31 23:25    [W:0.021 / U:118.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site