lkml.org 
[lkml]   [2007]   [May]   [31]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 31 May 2007 08:35:13 -0400
FromJeff Garzik <>
SubjectRe: 2.6.22-rc3-mm1
Cornelia Huck wrote:
> On Thu, 31 May 2007 06:15:57 -0600,
> Matthew Wilcox <matthew@wil.cx> wrote:
> 
>> On Thu, May 31, 2007 at 02:09:22PM +0200, Cornelia Huck wrote:
>>> I split those functions out into a new file. Builds on s390 and i386.
>> Why not just put #ifdef CONFIG_HAS_DMA / #endif around the pair of
>> functions?  I don't see the need to add a new Kconfig symbol and a new
>> file for this.
> 
> I prefer a new file over #ifdefs in c files. (New dma-dependent stuff
> would also have a place where it could go to.)
> 
> But I'll do whatever ends up as consensus :)

50 lines isn't much need for a new file.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-31 14:39    [from the cache]
©2003-2008