lkml.org 
[lkml]   [2007]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] Add /proc/sys/vm/compact_node for the explicit compaction of a node
    On Tue, 29 May 2007, Mel Gorman wrote:

    > + if (nodeid < 0)
    > + return -EINVAL;
    > +
    > + pgdat = NODE_DATA(nodeid);
    > + if (!pgdat || pgdat->node_id != nodeid)
    > + return -EINVAL;

    You cannot pass an arbitrary number to node data since NODE_DATA may do a
    simple array lookup.

    Check for node < nr_node_ids first.

    pgdat->node_id != nodeid? Sounds like something you should BUG() on.

    IA64's NODE_DATA is

    struct ia64_node_data {
    short active_cpu_count;
    short node;
    struct pglist_data *pg_data_ptrs[MAX_NUMNODES];
    };

    /*
    * Given a node id, return a pointer to the pg_data_t for the node.
    *
    * NODE_DATA - should be used in all code not related to system
    * initialization. It uses pernode data structures to minimize
    * offnode memory references. However, these structure are not
    * present during boot. This macro can be used once cpu_init
    * completes.
    */
    #define NODE_DATA(nid) (local_node_data->pg_data_ptrs[nid])

    x86_64 also does

    #define NODE_DATA(nid) (node_data[nid])

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-30 06:17    [W:0.023 / U:33.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site