Messages in this thread | | | Date | Wed, 30 May 2007 14:48:37 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH 2/3 -mm] slub: use lib/hexdump |
| |
Christoph Lameter wrote: > On Wed, 30 May 2007, Randy Dunlap wrote: > >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> Convert slub error memory dump functions to use lib/hexdump routines. >> Completely eliminate slub's print_section() function. > > I'd like to keep print_section around as it also does some other things. > Repeating the output formatting at the various call locations will make > it difficult to change if you add another whizbang feature.
I have no problems with keeping print_section() except that it's not used in the current tree after this patch. :)
> I have a patch here that I could sent out today if hexdump would work the > right way.
Please define "the right way."
-- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |