Messages in this thread | | | Date | Wed, 30 May 2007 23:37:55 +0200 (CEST) | From | Jan Kratochvil <> | Subject | Re: [PATCH] Support for controlling leds on xbox 360 pad. |
| |
Hi,
On Wed, 30 May 2007, Richard Purdie wrote: > On Wed, 2007-05-30 at 10:56 -0400, Dmitry Torokhov wrote: >> Do you think it makes sense to split the driver (and Kconfig options) >> between input and leds directories as Jan had done? I know that I >> prefer to keep anything input related in input directory because it >> makes my life as maintainer easier and I bet you prefer the same but >> it does not always work well for multifunction devices or devices >> using several subsystems... > > In ideal world having the code in drivers/leds would be preferred but if > you want to add the LED code directly to the input driver in this case I > have no objection and it probably makes sense. The LED code is already > spread about a bit anyway...
I wasn't happy about having this splited in two subsystems either. So I'll rewrite it to use led functionality directly from drivers/input/joystick/xpad.c.
Thanks for comments Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |