Messages in this thread | | | Date | Wed, 30 May 2007 13:58:52 -0700 | From | Yinghai Lu <> | Subject | Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250 |
| |
On Wednesday 30 May 2007 13:18, Andrew Morton wrote: > On Wed, 30 May 2007 12:58:11 -0700 > Yinghai Lu <Yinghai.Lu@Sun.COM> wrote: > > > >> +int update_console_cmdline(char *name, int idx, char *name_new, int idx_new, char *options) > > >> +{ > > >> + struct console_cmdline *c; > > >> + int i; > > >> + > > >> + for (i = 0; i < MAX_CMDLINECONSOLES && console_cmdline[i].name[0]; i++) > > >> + if (strcmp(console_cmdline[i].name, name) == 0 && > > >> + console_cmdline[i].index == idx) { > > >> + c = &console_cmdline[i]; > > >> + memcpy(c->name, name_new, sizeof(c->name)); > > >> + c->name[sizeof(c->name) - 1] = 0; > > >> + c->options = options; > > >> + c->index = idx_new; > > >> + return i; > > >> + } > > >> + /* not found */ > > >> + return -1; > > >> +} > > > > > > Shouldn't this be __init? > > > > > > serial8250_find_port_for_earlycon() had its __init removed. Why? > > with __init, the compiler will cry about .init.text and .text missection. > > But was this the correct fix for that? afaict the only caller of > this function is __init anyway. > You are right. serial8250_find_port_for_earlycon and update_console_cmdline in kernel/printk.c could be __init
YH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |