![]() | |||||||||||||
Messages in this thread |
On 5/30/07, Johannes Stezenbach <js@linuxtv.org> wrote: > On Wed, May 30, 2007, Nitin Gupta wrote: > > > > Again, all the original code has been retained _as-is_. Whatever was > > changed, has been mentioned in that detailed changelog that I post > > along with patch. > > Just a general remark (I haven't been following this thread closely): > > IMHO it would be _much_ better to merge the original code and > your changes as seperate patches. Then someone who > wants to review it later doesn't have to jump through all > the hoops of finding the original code himself to diff it > and see your changes. > > Additionally, you should also split stylistic/cleanup > changes like "Reformatted the code to match general kernel style" > from functional changes like "use cpu_to_le16()". > > Ideally each of the changes you mention in your > "Changelog vs. original LZO" should be a seperate > patch, this would make review much easier. I violently agree with this method of going forward. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-05-30 14:27 [from the cache] ©2003-2008 | |||||||||||||