![]() | |||||||||||||
Messages in this thread |
On 3/5/07 15:27, "Jeremy Fitzhardinge" <jeremy@goop.org> wrote: >> The function has an effect in page flipping mode only. It walks the >> whole list of rx skbufs (id is the loop variable ...), checks whenever >> they are handed out to the frontend driver to fill in packet data and >> not returned yet, and if so reclaim them ... > > Yes, but why use add_id_to_freelist? rx_skbs are not being used on a > freelist anywhere else. It just means the rx_skb array gets filled with > small integers, but the rest of the code assumes they're either NULL or > an skb pointer. The need for it went away when Herbert Xu made the mapping between receive-ring slots and receive-request/response identifiers static. I think there was a race between Gerd writing his patch, Herbert removing the need for add_id_to_freelist, and Gerd's patch being checked in. -- Keir - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-05-03 14:33 [from the cache] ©2003-2008 | |||||||||||||