lkml.org 
[lkml]   [2007]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Linux v2.6.22-rc3
    Jeff Garzik wrote:

    > Several people have reported LITE-ON LTR-48246S detection failed
    > because SETXFER fails. It seems the device raises IRQ too early after
    > SETXFER. This is controller independent. The same problem has been
    > reported for different controllers.
    >
    > So, now we have pata_via where the controller raises IRQ before it's
    > ready after SETXFER and a device which does similar thing. This patch
    > makes libata always execute SETXFER via polling. As this only happens
    > during EH, performance impact is nil. Setting ATA_TFLAG_POLLING is
    > also moved from issue hot path to ata_dev_set_xfermode() - the only
    > place where SETXFER can be issued.
    >
    > Note that ATA_TFLAG_POLLING applies only to drivers which implement
    > SFF TF interface and use libata HSM. More advanced controllers ignore
    > the flag. This doesn't matter for this fix as SFF TF controllers are
    > the problematic ones.
    >
    Not only kills two birds with a single store, but will avoid having to
    re-solve the problem at sometime in the future. That's good software!

    --
    Bill Davidsen <davidsen@tmr.com>
    "We have more to fear from the bungling of the incompetent than from
    the machinations of the wicked." - from Slashdot
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-28 23:53    [W:0.026 / U:30.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site