lkml.org 
[lkml]   [2007]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend
    Hi!

    > From: Rafael J. Wysocki <rjw@sisk.pl>
    >
    > Use a hibernation and suspend notifier to disable the firmware requesting
    > mechanism before a hibernation/suspend and enable it after the operation.
    >
    > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    >
    > drivers/base/firmware_class.c | 36 ++++++++++++++++++++++++++++++++++++
    > 1 file changed, 36 insertions(+)
    >
    > Index: linux-2.6.22-rc3/drivers/base/firmware_class.c
    > ===================================================================
    > --- linux-2.6.22-rc3.orig/drivers/base/firmware_class.c 2007-05-27 19:43:03.000000000 +0200
    > +++ linux-2.6.22-rc3/drivers/base/firmware_class.c 2007-05-27 19:44:06.000000000 +0200
    > @@ -17,6 +17,8 @@
    > #include <linux/bitops.h>
    > #include <linux/mutex.h>
    > #include <linux/kthread.h>
    > +#include <linux/notifier.h>
    > +#include <linux/suspend.h>
    >
    > #include <linux/firmware.h>
    > #include "base.h"
    > @@ -35,6 +37,9 @@ enum {
    >
    > static int loading_timeout = 60; /* In seconds */
    >
    > +/* If set, _request_firmware() will exit immediately returning -EBUSY */
    > +static int requesting_firmware_disabled;
    > +
    > /* fw_lock could be moved to 'struct firmware_priv' but since it is just
    > * guarding for corner cases a global lock should be OK */
    > static DEFINE_MUTEX(fw_lock);
    > @@ -397,6 +402,9 @@ _request_firmware(const struct firmware
    > struct firmware *firmware;
    > int retval;
    >
    > + if (requesting_firmware_disabled)
    > + return -EBUSY;

    WARN_ON()? This should not happen, and if it does, we'll end up with
    non-working device.
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-28 15:09    [W:4.155 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site