lkml.org 
[lkml]   [2007]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [condingstyle] Add chapter on tests
    On Sat, 26 May 2007, Jan Engelhardt wrote:

    > +Testing for a flag, as done in the following example, is redundant and
    > +can be shortened.
    > +
    > + if ((v & GFP_KERNEL) == GFP_KERNEL)
    > + return;
    > +
    > +should become
    > +
    > + if (v & GFP_KERNEL)
    > + return;

    This looks wrong to me. These two are only equivalent if the "flag" only
    has 1 bit. And already here you fall into this trap:

    #define GFP_KERNEL (__GFP_WAIT | __GFP_IO | __GFP_FS)

    Thanks
    Guennadi
    ---
    Guennadi Liakhovetski
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-27 23:05    [W:0.019 / U:59.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site