Messages in this thread | | | Date | Sat, 26 May 2007 10:51:01 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver |
| |
On Sat, 26 May 2007, Benjamin Herrenschmidt wrote: > On Fri, 2007-05-25 at 10:36 +0200, Geert.Uytterhoeven@sonycom.com wrote: > > -#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) > > +#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) || \ > > + defined(CONFIG_PS3_FLASH_MODULE) || > > defined(CONFIG_PS3_FLASH_MODULE) > > As I said multiple times, imho, #ifdef CONFIG_xxx_MODULE in the kernel > is always a bug. > > You should always be able to build the module out of tree afteward and > use it on a kernel that didn't have the CONFIG_xxx_MODULE set imho.
I know.
Do you know another way to allocate an aligned chunk of 256 KiB of physically contiguous memory, possibly a long time after boot up?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE) Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1 Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |