lkml.org 
[lkml]   [2007]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver
    From
    Date
    On Fri, 2007-05-25 at 10:36 +0200, Geert.Uytterhoeven@sonycom.com wrote:
    > -#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE)
    > +#if defined(CONFIG_FB_PS3) || defined(CONFIG_FB_PS3_MODULE) || \
    > + defined(CONFIG_PS3_FLASH_MODULE) ||
    > defined(CONFIG_PS3_FLASH_MODULE)

    As I said multiple times, imho, #ifdef CONFIG_xxx_MODULE in the kernel
    is always a bug.

    You should always be able to build the module out of tree afteward and
    use it on a kernel that didn't have the CONFIG_xxx_MODULE set imho.

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-26 00:39    [W:0.024 / U:59.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site