Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [patch 5/7] ps3: Disk Storage Driver | Date | Fri, 25 May 2007 22:43:41 +0200 |
| |
On Friday 25 May 2007, Geert Uytterhoeven wrote: > > > I don't really understand what the kthread is needed for. You probably > > thought about multiple options and ended up with this, but having > > a comment in front of it might be helpful. > > I used a kthread because the request function of a block device driver must be > non-blocking, and ps3stor_read_write_sectors() calls wait_for_completion().
Ok, but why does it call wait_for_completion() then? I thought you could end_that_request_* from the interrupt handler instead.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |