Messages in this thread | | | Date | Fri, 25 May 2007 08:02:51 +0200 | From | Cornelia Huck <> | Subject | Re: 2.6.22-rc1-mm1 - s390 vs. md |
| |
On Thu, 24 May 2007 15:11:08 -0700, "Williams, Dan J" <dan.j.williams@intel.com> wrote:
> --- a/async_tx/async_memcpy.c > +++ b/async_tx/async_memcpy.c > @@ -56,6 +56,7 @@ async_memcpy(struct page *dest, struct page *src, > unsigned int dest_offset, > int_en) : NULL; > > if (tx) { /* run the memcpy asynchronously */ > + #ifdef CONFIG_HAS_DMA > dma_addr_t dma_addr; > enum dma_data_direction dir;
Can you factor out the async stuff into a function so you can use the #ifdefs to define different functions rather than put them in the middle of a complex function?
(Maybe you should rather use #ifdef CONFIG_DMA_ENGINE, since the async part is not needed for !DMA_ENGINE either.) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |