lkml.org 
[lkml]   [2007]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] old declaration ritchie style fix
Jiri Slaby wrote:
> Yoann Padioleau napsal(a):
>> static int
>> -receivepkt (target, buffer)
>> - int target;
>> - unsigned char *buffer;
>> +receivepkt (int target, unsigned char *buffer)
>
> When you are at it, you can also get rid of bsd return-type-on-its-own-line
> style

return-type-on-its-own-line is IMO OK if it occurs consistently in a
file. It can improve readability particularly if long return types are
combined with long function names.

> + remove the space before parenthesis.

Indeed.
--
Stefan Richter
-=====-=-=== -=-= ==--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-25 10:43    [W:0.049 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site